ci: stop installing pynufft in workspace-validation - #162
Merged
Conversation
pynufft is no longer a dependency of any PyAuto library (PyAutoArray#475 dropped it from both the `optional` and `dev` extras), but the mode=release "Install TestPyPI wheels" step still installed `pynufft==2025.1.1`. Nothing imports it, so this was install time and resolver surface only — the pin is 2025.1.1, not the 2022.2.2 that hits the scipy.linalg.pinv2 failure, so no run was red. `numba` is kept (it shared the line), and the `nufftax>=0.6.1,<0.7.0` install below is the live NUFFT backend — untouched. Phase 3 of 3 of the pynufft-removal residue sweep (PyAutoHands#258). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7kFdoYcD6wnTifNXV5T98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PyAutoLabs/PyAutoHands#258 (phase 3 of 3 of the pynufft-removal residue sweep — this is the PyAutoHeart leg; PyAutoHands and PyAutoCTI carry their own PRs, and the three are independent).
What changed
One line, in
workspace-validation.yml'smode=release"Install TestPyPI wheels" step:pynufftis no longer a dependency of any PyAuto library (PyAutoArray#475 dropped it from both theoptionalanddevextras) and nothing in the stack imports it.numbais kept — it shared the line — and thenufftax>=0.6.1,<0.7.0install two lines below is the live NUFFT backend, untouched. No other file in this repo mentions pynufft.Why this is low-risk, and not urgent
The pin was 2025.1.1, not the broken
2022.2.2, so this was never hitting thescipy.linalg.pinv2failure and no run was red. It is install time and resolver surface only.Verification
This line lives in the
mode=releaseleg, reached only viarelease-integrate.yml(Brain Release Agent dispatch, after an M1 TestPyPI rehearsal) — the continuousmode=smokechannel never executed it, so ordinary PR CI cannot exercise it. Pre-merge signal is this repo's own PR checks plus the diff; full confirmation lands on the next release-validation run.Generated by Claude Code